Fix badge for CI build on the default branch - #17901
Conversation
PR Summary by QodoFix GitHub Actions CI badges to show push status on default branch
AI Description
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can group findings by type and pick your Finding display, from Minimal to Full |
cgoldberg
left a comment
cgoldberg
left a comment
There was a problem hiding this comment.
cool.. I had no idea the badges accepted args
|
I verified, it shows green. Let's keep eyes. Merging. |
|
Passing (previous commit)... While my commit is still in progress. |
|
"CI" workflow is only one from many others. Currently our badge looks at "CI". Seems it would be better that badge shows status of the latest commit in default branch. Not a priority, if somebody knows - nice. |
2 participants
This pull request makes a minor update to the
README.mdfile, specifically updating the CI badge image URLs to include the?event=pushquery parameter. This ensures that the badges reflect the status of push events.README.mdto include?event=push, so the badges display the status of push events.🔗 Related Issues
I eventually see red badge in README while CI workflow actually passed in the default branch.
Why is it red?
💥 What does this PR do?
Filter CI workflow status to be triggered by push event.
🔄 Types of changes